fix(frontend): fix select_trait_candidate #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franziskuskiefer
requested changes
Jan 31, 2024
There was a problem hiding this comment.
This makes hax crash. For example
Fatal error: exception Failure("impl_expr_atom: Todo ImplExprAtom::Todo(see https://github.com/hacspec/hax/issues/381) ImplSourceClosureData(closure_def_id=DefId(0:673 ~ bertie[019b]::tls13utils::{impl#3}::declassify::{closure#0}), substs=[i16, extern \"rust-call\" fn((&u8,)) -> u8, ()], nested=[Obligation(predicate=Binder(ClosureKind(DefId(0:673 ~ bertie[019b]::tls13utils::{impl#3}::declassify::{closure#0}), [i16, extern \"rust-call\" fn((&u8,)) -> u8, ()], FnMut), []), depth=1)])\n\nBinder(\n <[closure@src/tls13utils.rs:202:27: 202:30] as std::ops::FnMut<(&u8,)>>,\n [],\n)")
Raised at Stdlib.failwith in file "stdlib.ml", line 29, characters 17-33
Called from Hax_engine__Import_thir.Make.c_impl_expr in file "lib/import_thir.ml", line 906, characters 15-44
|
Yes, I noticed it's producing new bugs 😅 |
Co-authored-by: Son Ho <[email protected]>
W95Psp
force-pushed
the
fix-select-trait-candidate
branch
from
ebf9995 to
8d18742
Compare
W95Psp
force-pushed
the
fix-select-trait-candidate
branch
from
52c0166 to
8d18742
Compare
|
you force pushed again 😔 |
|
Great, thank you 😃 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #461 and #476